On Tue, 26 May 2026 23:25:50 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8381007
>
> src/java.desktop/share/classes/java/awt/image/MultiPixelPackedSampleModel.java
> line 124:
>
>> 122: if (dataType < DataBuffer.TYPE_BYTE ||
>> 123: (dataType > DataBuffer.TYPE_DOUBLE &&
>> 124: dataType != DataBuffer.TYPE_UNDEFINED))
>
> Why the TYPE_UNDEFINED is accepted? it will throw an exception a few line
> below when `DataBuffer.getDataTypeSize` be called.
I copied it from the super-class. I should have just moved up the test further
down the constructor. fixed.
> src/java.desktop/share/classes/java/awt/image/MultiPixelPackedSampleModel.java
> line 133:
>
>> 131: if (sls < 0) {
>> 132: throw new RasterFormatException("Pixels do not fit");
>> 133: };
>
> unnecessary semicolon
removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30826#discussion_r3307526089
PR Review Comment: https://git.openjdk.org/jdk/pull/30826#discussion_r3307523719
