On Fri, 17 Jul 2026 13:56:05 GMT, Matthias Baesken <[email protected]> wrote:
> Currently we have no configure option to disable the build of libjsound, so > we always try to build it and need the related dependencies. > an exception is AIX where we have the build disabled; it might make sense to > offer a configure option to disable the jsound build e.g. to build a headless > jdk for container envs where we do not have sound (the JCK offers options to > have a JDK without sound). > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Looks good, one minor style comment make/modules/java.desktop/Lib.gmk line 41: > 39: > 40: ifeq ($(ENABLE_JSOUND), true) > 41: ifeq ($(call isTargetOs, aix), false) I think these two ifeqs (!aix and enable_jsound) can be folded into one. ------------- Changes requested by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/31951#pullrequestreview-4797685389 PR Review Comment: https://git.openjdk.org/jdk/pull/31951#discussion_r3665852343
