On Wed, 16 Sep 2026 21:57:26 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update > > test/jdk/sun/java2d/SunGraphics2D/SourceClippingBlitTest/SourceClippingBlitTest.java > line 30: > >> 28: * @summary Tests that source is clipped correctly when blitting >> 29: * different types of images to the screen >> 30: * @run main/othervm -Dsun.java2d.uiScale=1 SourceClippingBlitTest > > Why do you need this parameter? I understand that it can cause some issues > for some tests, but you know, we cannot change all the tests here and there > to exclude the hidpi/transform code path which is default on most of the > systems. If the problem is in the downlscaling caused by the robot api, it > might be better to re-implement that part of the test via > robot.createMultiResolutionScreenCapture? This was added as additional guardrail. Updated test passed on macOS and Windows without uiScale=1 also. Since i have added image dump also, i will go ahead and remove uiScale=1. If in future we see some intermittent failure image dump will help. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32904#discussion_r4033265029
