On Thu, 17 Sep 2026 10:37:35 GMT, Jayathirth D V <[email protected]> wrote:

>> On macOS this test fails all the time because of rounded corners but we 
>> check for pixels even outside the rounder corners.
>> This test can also fail intermittently for edge pixels on HiDPI displays or 
>> because robot screen capture downsamples from absolute fractional scaled 
>> data on platforms like windows.
>> 
>> We are now using insets to avoid rounded corner issue, test is run with 
>> uiScale = 1 and we are excluding some edge pixels. Test is also updated to 
>> dump an image on failure for better debugging purpose.
>> 
>> On Linux we actually have blitting issue when we have source clipping and 
>> for that i have created a separate issue 
>> [JDK-8392471](https://bugs.openjdk.org/browse/JDK-8392471). Test is also 
>> verified in CI.
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Jayathirth D V has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Exclude intersection pixels

Because of color blending in some specific display scaling and resolution they 
will not be perfect green/red. I was able to verify this locally on my windows 
machine with 175% scaling.

Example of blended capture:
<img width="300" height="300" alt="SourceClippingBlitTest" 
src="https://github.com/user-attachments/assets/dce39a02-1471-4459-be99-3217e1036a66";
 />

I have updated the test to not check these intersecting pixels. The current 
form of test is reliable and verifies blitting with source clipping properly.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32904#issuecomment-5713024985

Reply via email to