> On macOS this test fails all the time because of rounded corners but we check 
> for pixels even outside the rounder corners.
> This test can also fail intermittently for edge pixels on HiDPI displays or 
> because robot screen capture downsamples from absolute fractional scaled data 
> on platforms like windows.
> 
> We are now using insets to avoid rounded corner issue, test is run with 
> uiScale = 1 and we are excluding some edge pixels. Test is also updated to 
> dump an image on failure for better debugging purpose.
> 
> On Linux we actually have blitting issue when we have source clipping and for 
> that i have created a separate issue 
> [JDK-8392471](https://bugs.openjdk.org/browse/JDK-8392471). Test is also 
> verified in CI.
> 
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Jayathirth D V has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains five commits:

 - Resolve conflict
 - Exclude intersection pixels
 - Update
 - Update
 - 8196185: 
sun/java2d/SunGraphics2D/SourceClippingBlitTest/SourceClippingBlitTest.java 
fails

-------------

Changes: https://git.openjdk.org/jdk/pull/32904/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=32904&range=04
  Stats: 60 lines in 2 files changed: 31 ins; 6 del; 23 mod
  Patch: https://git.openjdk.org/jdk/pull/32904.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/32904/head:pull/32904

PR: https://git.openjdk.org/jdk/pull/32904

Reply via email to