Hello, 2 quick remarks concerning the patch:
* type hints are written like #^String and not ^String * why ltrim / rtrim , but upper-case / lower-case ? Why not ltrim / rtrim + ucase / lcase , or left-trim right-trim + upper-case / lower-case ? Will left-trim/right-trim be so often used that they must be shortened to ltrim/rtrim (especially compared to upper-case / lower-case) ? Oh and also, with some IDEs, having left-trim enables the possibility to write l-t and then have autocomplete work by expanding to left-trim (so it's more readable, and it's even faster to write with the right tools :-) ). My 0,02€, -- Laurent 2010/6/2 ataggart <alex.tagg...@gmail.com> > +1 on uppercase / lowercase > > On Jun 2, 8:49 am, Tom Hickey <thic...@gmail.com> wrote: > > Including a space is correct when changing a string "to upper > > case" (hence Java's toUpperCase), though no space would be fine there > > as well. > > > > As a verb, "uppercase" (no space) is correct. So the function should > > either match java and be called to-upper-case or (preferably, IMO) > > simply be uppercase. > > > > Tom > > > > On May 30, 11:23 pm, Stuart Halloway <stuart.hallo...@gmail.com> > > wrote: > > > > > > > > > But they can be separate words, and Java treats them so (.toUpperCase, > .toLowerCase). > > > > > Stu > > > > > > Also, according to Merriam-Webster, uppercase and lowercase don't > have > > > > hyphens in them. > > > > > > RJ > > > > > > On May 30, 3:49 pm, Stuart Halloway <stuart.hallo...@gmail.com> > wrote: > > > >> I have been working on a branch [1] and haven't updated the ticket > yet [2]. Given the number of diverse (and sometimes opposite!) opinions > already expressed on this topic, I thought a little extra community review > would be in order. David and I organized the work into several fairly small > commits so you can grab the branch and see the individual decisions being > made. > > > > > >> Thanks! > > > >> Stu > > > > > >> [1]http://github.com/stuarthalloway/clojure/tree/string > > > >> [2] > https://www.assembla.com/spaces/clojure/tickets/359-promote-contrib-s... > > > > > > -- > > > > You received this message because you are subscribed to the Google > > > > Groups "Clojure" group. > > > > To post to this group, send email to clojure@googlegroups.com > > > > Note that posts from new members are moderated - please be patient > with your first post. > > > > To unsubscribe from this group, send email to > > > > clojure+unsubscr...@googlegroups.com<clojure%2bunsubscr...@googlegroups.com> > > > > For more options, visit this group at > > > >http://groups.google.com/group/clojure?hl=en > > -- > You received this message because you are subscribed to the Google > Groups "Clojure" group. > To post to this group, send email to clojure@googlegroups.com > Note that posts from new members are moderated - please be patient with > your first post. > To unsubscribe from this group, send email to > clojure+unsubscr...@googlegroups.com<clojure%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/clojure?hl=en > -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en
