I'm not sure how useful unexpanding analyzer will actually be useful for Codeq, especially if you want to do analysis like "who calls this function" from it. Forms passed to a macro aren't necessarily going to be useful as unexpanded forms. eg. a macro that rewrites (+ 1 2) to (plus 1 2) might count as a call to clojure.core/+.
Have you considered these issues? Will you have a tolerance for false positives? Thanks, Ambrose On Wed, May 1, 2013 at 3:47 PM, Ambrose Bonnaire-Sergeant < abonnaireserge...@gmail.com> wrote: > Hi Navgeet, > > Yes CinC is a big job. > > Ah, I read the proposal more closely. I think you're on the right track. > You should only need one more AST node for unexpanded macros, or maybe > even just extra metadata on the :invoke :op. > > As a quick and dirty approach I like it. > > Thanks, > Ambrose > > On Wed, May 1, 2013 at 3:29 PM, Navgeet Agrawal <navgeet.agra...@gmail.com > > wrote: > >> Hi Ambrose, >> >> Agreed, using CinC to analyze would be the best way. However given the >> wish list [1], I do not feel its suitable for me. >> Btw, I meant extending Codeq's analyzer rather than rewriting >> jvm.tools.analyzer. >> >> [1]: http://dev.clojure.org/display/design/Compiler+in+Clojure >> >> >> Cheers >> Navgeet >> >> -- >> -- >> You received this message because you are subscribed to the Google >> Groups "Clojure" group. >> To post to this group, send email to clojure@googlegroups.com >> Note that posts from new members are moderated - please be patient with >> your first post. >> To unsubscribe from this group, send email to >> clojure+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/clojure?hl=en >> --- >> You received this message because you are subscribed to the Google Groups >> "Clojure" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to clojure+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > > -- -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
