Thanks, Sean.  Not sure through what channel you want to communicate.  

I have pushed some changes that significantly clean up the code:

   - Use reg ex as you suggest
   - Eliminated reflection warnings
   - Learned me a zipmap for great success
   

On Wednesday, July 24, 2013 7:09:27 PM UTC-7, Sean Corfield wrote:
>
> I'll reply off-list. There's a lot of stuff in that code to digest. 
> I'll say straight off that I think a regex replace would make the 
> clojurize-java-accessor code much simpler. I suspect there are 
> reflection warnings in several places that will need to be addressed 
> and definitely some refactoring to do... 
>
> Sean 
>
> On Wed, Jul 24, 2013 at 6:47 PM, Mark <markad...@gmail.com <javascript:>> 
> wrote: 
> > re Signing the CA:  Definitely.  I'll get that sent in ASAP. 
> > 
> > In the meantime, can you take a look at 
> > 
> https://github.com/markaddleman/java.jdbc/commit/27a246dee7c0a06c888d827e0699bc6966725b58
>  
> > ?  I'm still a Clojure noob so I'm not sure if the approach is correct. 
>  All 
> > feedback welcome. 
> > 
> > 
> > 
> > 
> > On Wednesday, July 24, 2013 4:21:56 PM UTC-7, Sean Corfield wrote: 
> >> 
> >> That's great and would be a worthwhile addition but don't forget to 
> >> get your CA signed and sent in, otherwise your contributions cannot be 
> >> accepted. See http://clojure.org/contributing for more details. 
> >> 
> >> Sean 
> >> 
> >> On Wed, Jul 24, 2013 at 4:03 PM, Mark <markad...@gmail.com> wrote: 
> >> > I'm pretty interested in getting at least a subset of jdbc metadata 
> >> > support 
> >> > into clojure.java.jdbc.  I've forked the repo and will start crafting 
> >> > the 
> >> > API if there is no else has a similar effort going on.  I'm mostly 
> >> > interested in result set metadata.  My first thought is to extend the 
> >> > query 
> >> > function to support an optional "metadata?" key.  If true, the query 
> >> > function would attach a the data structure equivalent of the 
> >> > ResultSetMetadata structure as metadata to the returned map. 
> >> > 
> >> > Thoughts? 
> >> > 
> >> > -- 
> >> > -- 
> >> > You received this message because you are subscribed to the Google 
> >> > Groups "Clojure" group. 
> >> > To post to this group, send email to clo...@googlegroups.com 
> >> > Note that posts from new members are moderated - please be patient 
> with 
> >> > your 
> >> > first post. 
> >> > To unsubscribe from this group, send email to 
> >> > clojure+u...@googlegroups.com 
> >> > For more options, visit this group at 
> >> > http://groups.google.com/group/clojure?hl=en 
> >> > --- 
> >> > You received this message because you are subscribed to the Google 
> >> > Groups 
> >> > "Clojure" group. 
> >> > To unsubscribe from this group and stop receiving emails from it, 
> send 
> >> > an 
> >> > email to clojure+u...@googlegroups.com. 
> >> > For more options, visit https://groups.google.com/groups/opt_out. 
> >> > 
> >> > 
> >> 
> >> 
> >> 
> >> -- 
> >> Sean A Corfield -- (904) 302-SEAN 
> >> An Architect's View -- http://corfield.org/ 
> >> World Singles, LLC. -- http://worldsingles.com/ 
> >> 
> >> "Perfection is the enemy of the good." 
> >> -- Gustave Flaubert, French realist novelist (1821-1880) 
> > 
> > -- 
> > -- 
> > You received this message because you are subscribed to the Google 
> > Groups "Clojure" group. 
> > To post to this group, send email to clo...@googlegroups.com<javascript:> 
> > Note that posts from new members are moderated - please be patient with 
> your 
> > first post. 
> > To unsubscribe from this group, send email to 
> > clojure+u...@googlegroups.com <javascript:> 
> > For more options, visit this group at 
> > http://groups.google.com/group/clojure?hl=en 
> > --- 
> > You received this message because you are subscribed to the Google 
> Groups 
> > "Clojure" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an 
> > email to clojure+u...@googlegroups.com <javascript:>. 
> > For more options, visit https://groups.google.com/groups/opt_out. 
> > 
> > 
>
>
>
> -- 
> Sean A Corfield -- (904) 302-SEAN 
> An Architect's View -- http://corfield.org/ 
> World Singles, LLC. -- http://worldsingles.com/ 
>
> "Perfection is the enemy of the good." 
> -- Gustave Flaubert, French realist novelist (1821-1880) 
>

-- 
-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to