There actually is a dependency cycle in manifold, it's just not in the
ns macro:

manifold.stream.graph depends on manifold.graph here:
https://github.com/ztellman/manifold/blob/master/src/manifold/stream/graph.clj#L5
maniphold.stream depends on manifold.stream.graph here:
https://github.com/ztellman/manifold/blob/master/src/manifold/stream.clj#L410

Whether or not this will be considered a regression or not, it's not up
to me to decide. I suggest opening a ticket in JIRA to discuss this
further.

Nicola

Andy Fingerhut writes:

> I can reproduce this.  I have also determined that the change in behavior
> is due to the patch applied for ticket CLJ-1544 [1] [2].  There doesn't
> appear to be an actual dependency cycle in the manifold lib, but I've only
> looked at this for a few mins.
>
> Andy
>
> [1] http://dev.clojure.org/jira/browse/CLJ-1544
> [2]
> https://github.com/clojure/clojure/commit/e5a104e894ed82f244d69513918d570cee5df67d
>
> On Wed, Jan 14, 2015 at 6:29 AM, Janne Lemmetti <jlemme...@gmail.com> wrote:
>
>> I noticed that with alpha5, I can no longer build an uberjar with {:aot
>> :all} if I depend on [gloss "0.2.4"]:
>>
>> $ lein uberjar
>> Compiling alpha5-test.core
>> java.lang.Exception: Cyclic load dependency: [ /manifold/stream
>> ]->/manifold/stream/graph->[ /manifold/stream
>> ]->/byte_streams->/gloss/core/formats->/gloss/data/bytes->/gloss/core/codecs->/gloss/io->/alpha5_test/core,
>> compiling:(manifold/stream/graph.clj:1:1)
>> at clojure.core$throw_if.doInvoke(core.clj:5612)
>> at clojure.lang.RestFn.invoke(RestFn.java:442)
>> at clojure.core$check_cyclic_dependency.invoke(core.clj:5763)
>> at clojure.core$load.doInvoke(core.clj:5860)
>> ...
>>
>> Minimal project to reproduce with:
>>
>> project.clj:
>>
>> (defproject alpha5-test "0.1.0-SNAPSHOT"
>> :dependencies [[org.clojure/clojure "1.7.0-alpha5"] [gloss "0.2.4"]]
>> :profiles {:uberjar {:aot :all}})
>>
>> src/alpha5_test/core.clj:
>>
>> (ns alpha5-test.core (:require [gloss.io :refer [decode-all]]))
>>
>>
>> Br, Janne
>>
>>
>> On Sunday, 11 January 2015 16:34:07 UTC+2, Alex Miller wrote:
>>>
>>> I would greatly appreciate hearing any feedback about this (or any other)
>>> alpha, even if it's just: everything looks ok.
>>>
>>> We've had a couple of regressions reported and that is hugely helpful as
>>> we can quickly turn around fixes for the next one.
>>>
>>> Interested particularly in: regressions, performance +/-, and for this
>>> alpha, AOT.
>>
>>  --
>> You received this message because you are subscribed to the Google
>> Groups "Clojure" group.
>> To post to this group, send email to clojure@googlegroups.com
>> Note that posts from new members are moderated - please be patient with
>> your first post.
>> To unsubscribe from this group, send email to
>> clojure+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/clojure?hl=en
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Clojure" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to clojure+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

--

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to