On 19 dec 2013, at 23:10, David Nolen <[email protected]> wrote:
> On Thu, Dec 19, 2013 at 5:02 PM, Dan Holmsand <[email protected]> wrote: > You also seem to call React asynchronously. That may be good for performance, > but doesn't makes testing awfully cumbersome? Why not rely on React's own > batching? > > React's batching depends on setState, which I don't want to get involved in > for many reasons. As far as testing, we could supply a flag to disable it. Actually, you don't have to use setState: you get batching from forceUpdate as well (which is what I used in the benchmark). > > I tried to replicate your benchmark here (not sure I got it quite right), and > results in the same ballpark (around 10ms for your "benchmark 2"): > > https://github.com/holmsand/cloact/blob/benchmark/examples/todomvc/src/todomvc.cljs > > Thanks for a good read. React is really cool (and ClojureScript even > cooler...). > > /dan > > Yes you're likely able to leverage batching on setState. > > I think your design is perfectly valid but it's not one I'm particularly > interested in investigating at the moment. I think treating the UI purely as > EDN simplifies Om's implementation significantly and I have some other ideas > like Datomic style Datalog queries to compute children in the works that will > be simpler to implement with the Om design. > > David > > -- > Note that posts from new members are moderated - please be patient with your > first post. > --- > You received this message because you are subscribed to a topic in the Google > Groups "ClojureScript" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/clojurescript/4wFYpXRGbqw/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/clojurescript. -- Note that posts from new members are moderated - please be patient with your first post. --- You received this message because you are subscribed to the Google Groups "ClojureScript" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/clojurescript.
