Hey Olga, Now that we have a review board up and running, would you mind posting any patch requests there? The URL is https://reviews.apache.org/, just assign me or jessica as the reviewer. You don't have to submit requests for anything we already merged into master.
Easier for us to track that way :) Thanks! Brian On 6/22/12 10:52 AM, "Brian Federle" <[email protected]> wrote: >Verified CS-12478, will merge to master. > >http://bugs.cloudstack.org/browse/CS-12478 > >On 6/19/12 2:49 PM, "Brian Federle" <[email protected]> wrote: > >>Olga, >> >>I have verified and merged in your patches to ASF master, for the >>following UI bugs: >> >>http://bugs.cloudstack.org/browse/CS-14010 >> >>http://bugs.cloudstack.org/browse/CS-14230 >> >>Thanks, >>Brian >> >>From: Pranav Saxena >><[email protected]<mailto:[email protected]>> >>Date: Wed, 13 Jun 2012 03:30:00 -0700 >>To: "Olga Smola ([email protected]<mailto:[email protected]>)" >><[email protected]<mailto:[email protected]>> >>Cc: >>"[email protected]<mailto:cloudstack-users@incubator. >>a >>pache.org>" >><[email protected]<mailto:cloudstack-users@incubator. >>a >>pache.org>>, Jessica Wang >><[email protected]<mailto:[email protected]>>, Brian Federle >><[email protected]<mailto:[email protected]>>, Will Chan >><[email protected]<mailto:[email protected]>>, David Nalley >><[email protected]<mailto:[email protected]>> >>Subject: RE: CloudStack bugs, CS-14896 >> >>No problems Olga. Feel free to check in your patches. >> >>Regards, >>Pranav >> >>From: Olga Smola [mailto:[email protected]] >>Sent: Wednesday, June 13, 2012 3:57 PM >>To: Pranav Saxena >>Subject: Re: CloudStack bugs, CS-14896 >> >>Pranav, >> >>thank you. >>On Wed, Jun 13, 2012 at 1:22 PM, Pranav Saxena >><[email protected]<mailto:[email protected]>> wrote: >>Hi Olga , >> >>Your patch looks perfect . The code looks similar to the diff file you >>had attached yesterday apart from few extra curly braces which are >>present in the patch now . Actually I had myself put those extra curly >>braces at appropriate places (which were missing in the diff file)to >>verify your code changes. I¹ll ask Brian /Jessica to merge your patch. >> >>Thanks & Regards, >>Pranav >>From: Olga Smola >>[mailto:[email protected]<mailto:[email protected]>] >>Sent: Wednesday, June 13, 2012 3:31 PM >>To: Pranav Saxena >>Cc: Jessica Wang; >>[email protected]<mailto:[email protected] >>p >>ache.org>; David Nalley ([email protected]<mailto:[email protected]>); Brian >>Federle; Sonny Chhen; Will Chan >> >>Subject: Re: CloudStack bugs, CS-14896 >> >>Hi Pranav, >> >>I've just attached git patch to >>http://bugs.cloudstack.org/browse/CS-14230, could you please check if >>it's correct? >> >>Thanks, Olga. >>On Tue, Jun 12, 2012 at 10:33 PM, Pranav Saxena >><[email protected]<mailto:[email protected]>> wrote: >>Hi Olga, >> >>I have reviewed your patch for this bug as well - >>http://bugs.cloudstack.org/browse/CS-14230 . This is what I have to say - >> >>1) The patch looks good but since you had attached the diff file , there >>was misplacement of the curly braces which was making the situation a >>little tedious for us to put your patch at the appropriate places , >>eventually leading to unnecessary errors . So will it be possible for you >>to follow the git workflow instead of attaching diffs ? This would help >>us in reviewing your code more easily and would make the process even >>more faster. >> >>2) Is it possible for you to make your own private branch ? ( I am not >>sure about this ) >> >>Otherwise , the patch is perfect and works absolutely fine . Good work >>!:) >> >>Thanks & Regards, >>Pranav >> >>-----Original Message----- >>From: Jessica Wang >>Sent: Tuesday, June 12, 2012 11:31 PM >>To: Pranav Saxena; Olga Smola >>([email protected]<mailto:[email protected]>); >>[email protected]<mailto:[email protected] >>p >>ache.org>; David Nalley ([email protected]<mailto:[email protected]>) >>Cc: Brian Federle; Sonny Chhen; Will Chan >>Subject: RE: CloudStack bugs, CS-14896 >> >>CS-14111 (There is no option to Edit IP ranges of Management Traffic) is >>invalid. >>I've written down my comment and close the bug as "By design". >> >>http://bugs.cloudstack.org/browse/CS-14111 >> >>-----Original Message----- >>From: Pranav Saxena >>Sent: Tuesday, June 12, 2012 9:39 AM >>To: Olga Smola ([email protected]<mailto:[email protected]>); >>[email protected]<mailto:[email protected] >>p >>ache.org>; David Nalley ([email protected]<mailto:[email protected]>) >>Cc: Jessica Wang; Brian Federle; Sonny Chhen; Will Chan >>Subject: RE: CloudStack bugs, CS-14896 >> >>Hi Olga , >> >>I have reviewed the following bugs fixed by you and this is what I have >>found - >> >>1) http://bugs.cloudstack.org/browse/CS-14511 - This bug seems to be >>already fixed in 3.0.3 release . Though your patch of code was perfect. >>2) http://bugs.cloudstack.org/browse/CS-13535 - This patch of code works >>perfect. The bug was reproducible and the spinner never stopped once you >>created a child domain with the same name. (Brian you could verify it >>once more). >>3) http://bugs.cloudstack.org/browse/CS-12478 - This has also been >>verified. The patch looks good according to me . >> >>The patches for the other bugs have already been merged or are getting >>reviwed. >> >>Thanks & Regards, >>Pranav >> >> >>-----Original Message----- >>From: David Nalley [mailto:[email protected]<mailto:[email protected]>] >>Sent: Tuesday, June 12, 2012 7:25 PM >>To: Pranav Saxena >>Cc: Jessica Wang; Brian Federle; Sonny Chhen; Will Chan >>Subject: Re: CloudStack bugs, CS-14896 >> >>Ohhh please do this! >> >>If you publicly review all of her existing patches I'll happily propose >>you as a committer. (and I'll happily take care of merges too should >>Jessica/Brian/Sonny not have issues with this process.) >> >>--David >> >>On Tue, Jun 12, 2012 at 9:43 AM, Pranav Saxena >><[email protected]<mailto:[email protected]>> wrote: >>> Hi Olga, >>> >>> I am also a UI developer here. I have reviewed most of your diffs >>>which you have attached with the respective bug tickets and will look at >>>the remaining ones very soon .They look good to me. I 'll also ask >>>Jessica /Brian ( Senior UI developers here ) to merge your patches once >>>they are also satisfied with your code changes .In case there are any >>>issues , they'll let you know regarding any further modifications >>>required. >>> >>> Thanks & Regards, >>> Pranav Saxena >>> >>> -----Original Message----- >>> From: Nitin Mehta >>>[mailto:[email protected]<mailto:[email protected]>] >>> Sent: Tuesday, June 12, 2012 5:40 PM >>> To: Olga Smola; >>>[email protected]<mailto:[email protected] >>>h >>>e.org>; Jessica Wang >>> Subject: RE: CloudStack bugs, CS-14896 >>> >>> This is good work Olga. Were you able to subscribe to the lists I >>> forwarded you below ? If not, I advise you to do so asap. There is a >>> way for you to submit your work in form of patches. Refer to the wiki >>> http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+w >>> orld#Gitworkflowinthebravenewworld-Non-committerworkflow >>> I am copying you on the dev list to get you going and Jessica is the >>>maintainer of the UI component so she should be able to help review your >>>work but, you need to follow the procedure in the wiki above to submit >>>your work. >>> Also once again I request you to subscribe to the Distribution lists >>>below. >>> >>> >>> Thanks, >>> -Nitin >>> >>> From: Olga Smola >>>[mailto:[email protected]<mailto:[email protected]>] >>> Sent: Tuesday, June 12, 2012 4:09 PM >>> To: Nitin Mehta >>> Subject: Re: CloudStack bugs, CS-14896 >>> >>> Hi Nitin, >>> >>> could you please help me to ask somebody to review the tickets I've >>>already completed? >>> I've started to work on CloudStack bugs a week ago and I have solutions >>>for: >>> http://bugs.cloudstack.org/browse/CS-14511 >>> http://bugs.cloudstack.org/browse/CS-13535 >>> http://bugs.cloudstack.org/browse/CS-14111 >>> http://bugs.cloudstack.org/browse/CS-14010 (was reviewed yesterday) >>> http://bugs.cloudstack.org/browse/CS-12478 >>> http://bugs.cloudstack.org/browse/CS-14230 >>> http://bugs.cloudstack.org/browse/CS-14896 >>> and now I'm working on http://bugs.cloudstack.org/browse/CS-4460. >>> >>> I can spend some time to work on CloudStack, so if there is actual UI >>>ticket, I can work on it. But I don't know to whom should I write to get >>>a feedback. >>> >>> Best regards, Olga. >>> On Mon, Jun 11, 2012 at 3:35 PM, Olga Smola >>><[email protected]<mailto:[email protected]><mailto:olya.smola@gma >>>i >>>l.com<mailto:[email protected]>>> wrote: >>> Nitin, >>> >>> thanks, I'll write to you if any problems. Have a good day! >>> >>> On Mon, Jun 11, 2012 at 1:58 PM, Nitin Mehta >>><[email protected]<mailto:[email protected]><mailto:Nitin.Meht >>>a >>>@citrix.com<mailto:[email protected]>>> wrote: >>> Olga - Please do let me know in case you have a problem catching >>> somebody to review your code >>> >>> From: Olga Smola >>> >>>[mailto:[email protected]<mailto:[email protected]><mailto:olya.sm >>>o >>>[email protected]<mailto:[email protected]>>] >>> Sent: Monday, June 11, 2012 4:26 PM >>> To: Nitin Mehta >>> Subject: Re: CloudStack bugs, CS-14896 >>> >>> Hi Nitin, >>> >>> thanks a lot. >>> On Mon, Jun 11, 2012 at 12:45 PM, Nitin Mehta >>><[email protected]<mailto:[email protected]><mailto:Nitin.Meht >>>a >>>@citrix.com<mailto:[email protected]>>> wrote: >>> Olga - This is superb. Since CS has been donated to Apache Server >>>foundation now you can more easily contribute your code (initially as >>>patch) and become a committer. >>> I would suggest you to subscribe to the following lists to get going. >>> >>> >>>[email protected]<mailto:cloudstack-comm >>>i >>>[email protected]><mailto:cloudstack-co<mailto:cloudstac >>>k >>>-co> >>> >>>[email protected]<mailto:[email protected] >>>a >>>che.org>> >>> >>>[email protected]<mailto:cloudstack-dev-subs >>>c >>>[email protected]><mailto:cloudstack-dev-su<mailto:cloudstack-de >>>v >>>-su> >>> [email protected]<mailto:[email protected]>> >>> >>>[email protected]<mailto:cloudstack-users- >>>s >>>[email protected]><mailto:cloudstack-user<mailto:cloudstack- >>>u >>>ser> >>> >>>[email protected]<mailto:[email protected] >>>> >>>> >>> >>> Just send an email to them to subscribe. >>> >>> Refer to this for creating a patch >>> http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+w >>> orld#Gitworkflowinthebravenewworld-Non-committerworkflow >>> >>> >>> Thanks again, >>> -Nitin >>> >>> From: Olga Smola >>> >>>[mailto:[email protected]<mailto:[email protected]><mailto:olya.sm >>>o >>>[email protected]<mailto:[email protected]>>] >>> Sent: Monday, June 11, 2012 2:59 PM >>> To: Nitin Mehta >>> Subject: CloudStack bugs, CS-14896 >>> >>> Hi Nitin, >>> >>> excuse me to bother you. My name is Olga, and I'm interested in work on >>>CloudStack. I'm UI developer and I can help to fix, extend project's UI. >>>I saw your post on http://bugs.cloudstack.org/browse/CS-14896 and I >>>think that my fix should help to you. Also I've fixed several other bugs >>>(http://bugs.cloudstack.org (http://bugs.cloudstack.org/browse/CS-14511, >>>http://bugs.cloudstack.org/browse/CS-13535, >>>http://bugs.cloudstack.org/browse/CS-14111), but I don't know how can I >>>get the feedback. Maybe you know whom can I write to review my fixes? >>> >>> Best regards, Olga Smola. >>> >>> >>> >> >> >
