[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469847#comment-13469847
 ] 

Marcus Sorensen commented on CLOUDSTACK-210:
--------------------------------------------

I'd say so. Especially if it's such a minor fix. I understand we'd probably 
want to wait on overhauling the snapshot function to use external ones, but if 
we can avoid breaking the existing functionality just by adjusting the grep 
that seems worthwhile.
                
> KVM Snapshot fails on RHEL 6.3 because of qemu-img help text differences
> ------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-210
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-210
>             Project: CloudStack
>          Issue Type: Bug
>          Components: KVM
>    Affects Versions: pre-4.0.0
>            Reporter: Prasanna Santhanam
>            Assignee: edison su
>             Fix For: 4.1.0
>
>
> From: http://markmail.org/thread/fndid26baau3sxdl
> On Wed, Sep 26, 2012 at 08:23:31AM -0400, Sowmya Krishnan wrote:
> > Here's the output on Ubuntu:
> > qemu-img --help|grep convert |grep snapshot
> >   convert [-c] [-p] [-f fmt] [-t cache] [-O output_fmt] [-o options] [-s 
> > snapshot_name] [-S sparse_size] filename [filename2 [...]] output_filename
> > 
> > which is similar to RHEL6.2:
> > qemu-img --help|grep convert |grep snapshot
> >   convert [-c] [-p] [-f fmt] [-t cache] [-O output_fmt] [-o options] [-s 
> > snapshot_name] [-S sparse_size] filename [filename2 [...]] output_filename
> >
> > Returns null on RHEL6.3:
> > [root@rhel63 ~]# qemu-img --help|grep convert |grep snapshot
> > [root@rhel63 ~]#
> Thanks, Could you post a bug?
> The issue seems to be in
>  
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
> 4289     private boolean isSnapshotSupported() {
> 4290         String result = executeBashScript("qemu-img --help|grep -E 
> convert|snapshot");
> 4291         if (result != null) {
> 4292             return false;
> 4293         } else {
> 4294             return true;
> 4295         }
> 4296     }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to