----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8248/#review13809 -----------------------------------------------------------
Radoslaw, nice tool. Can you see few issues: 1. Make python code PEP8 compliant and fix trailing spaces as per the coding conventions (http://docs.cloudstack.org/CloudStack_Documentation/Design_Documents/Coding_Conventions). Download the pep8 tool and fix code: pip install pep8 pep8 <cs-bugtool> Fix whatever it reports 2. Chmod +x cs-bugtool, so it's an executable by default 3. For the shebang interpretor use this path: /usr/bin/python, /usr/bin/env does not exist for other than Linux distros, /usr/bin/python is standard for most Linux distros and Macs. But assuming this would be used by users, how is a user supposed to use it? Logs can have sensitive information (api, mgmt server logs for example with auth, keys information, access logs with full urls and sensitive values such as passwords and keys as arguments). Maybe we can identify such string patterns and search and replace them, add code for doing that? 4. This is using zip (which assumes zip tool is preinstalled and which is the case for most installations), may be make it pure python so as to avoid external dependencies, like explore built in packages such as http://docs.python.org/2/library/zipfile And make sure whatever shell tools the script would execute, they are available for standard installations. 5. Add help docs in README. - Rohit Yadav On Nov. 28, 2012, 2:33 p.m., Radoslaw Smigielski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8248/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2012, 2:33 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > The main purpose behind cs-bugtool is to make easier collecting > logs required for CloudStack/CloudPlatform troubleshooting > and it mainly comes from Support. cs-bugtool collects logs, system > information and cloud database dump, compress everything and creates > .zip archive file ready to share with others. > For those familiar with Xen/XenServer cs-bugtool name may sound similar > to xen-bugtool, this similarity is intentional. > > Current version of cs-bugtool collects: > - basic system and environment information > - CP/CS management service logs > - basic system logs > - cloud database > > Current version does not accept any arguments but this may > changed in next iterations of cs-bugtool. > > We DO NOT collect and do not want to collect any sensitive information. > If there is still any sensitive pice of information please let us know > and we will try to remove it or replace by meaningless data. > > > Diffs > ----- > > tools/support/README PRE-CREATION > tools/support/cs-bugtool PRE-CREATION > > Diff: https://reviews.apache.org/r/8248/diff/ > > > Testing > ------- > > I tested this on CS 3.0.4 and 3.0.5. > > > Thanks, > > Radoslaw Smigielski > >
