----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8468/#review14295 -----------------------------------------------------------
CLOUDSTACK-197 is the generic Query API bug - but doesn't have anything to do with the failure of AuthorizeSecurityGroupIngress problem. Can we create a bug for that (so when people who have that problem google, they'll see when it is fixed) and also can we make sure that the entire Query API effort also results in having unit tests written for that portion of the code? - David Nalley On Dec. 11, 2012, 11:44 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8468/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 11:44 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > Before making the AuthorizeSecurityGroupIngress CloudStack API call, parse > the string arguments 'FromPort' and 'ToPort' as an integer. > > > This addresses bug CLOUDSTACK-197. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 4f74873 > > Diff: https://reviews.apache.org/r/8468/diff/ > > > Testing > ------- > > After setting up AWSAPI, using the boto client called > authorize_security_group(group_name=<sg_name>, ip_protocol=<protocol>, > from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>) > Successfully created the specified rule in the security-group. > > > Thanks, > > Likitha Shetty > >
