Sure David. I will create bugs under the umbrella ticket CLOUDSTACK-197 to correspond to each of the EC2 Query API issue.
Regarding unit tests, from the following mail thread http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201210.mbox/<7914B38A4445B34AA16EB9F1352942F1012F109D6278%40SJCPMAILBOX01.citrite.net<http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201210.mbox/%3c7914B38A4445B34AA16EB9F1352942F1012F109D6278%40SJCPMAILBOX01.citrite.net>> I understand we can run the ec2 test suite provided by jClouds to test CS AWSAPI. So improving its coverage should help ? Thank you, Likitha From: David Nalley [mailto:nore...@reviews.apache.org] On Behalf Of David Nalley Sent: Tuesday, December 11, 2012 10:20 PM To: Prachi Damle Cc: cloudstack; David Nalley; Likitha Shetty Subject: Re: Review Request: [EC2 Query API] AuthorizeSecurityGroupIngress fails with 'Server.InternalError 431 Invalid protocol' error. This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8468/ CLOUDSTACK-197 is the generic Query API bug - but doesn't have anything to do with the failure of AuthorizeSecurityGroupIngress problem. Can we create a bug for that (so when people who have that problem google, they'll see when it is fixed) and also can we make sure that the entire Query API effort also results in having unit tests written for that portion of the code? - David On December 11th, 2012, 11:44 a.m., Likitha Shetty wrote: Review request for cloudstack and Prachi Damle. By Likitha Shetty. Updated Dec. 11, 2012, 11:44 a.m. Description Before making the AuthorizeSecurityGroupIngress CloudStack API call, parse the string arguments 'FromPort' and 'ToPort' as an integer. Testing After setting up AWSAPI, using the boto client called authorize_security_group(group_name=<sg_name>, ip_protocol=<protocol>, from_port=<from_port>, to_port=<to_port>, cidr_ip=<cidr>) Successfully created the specified rule in the security-group. Bugs: CLOUDSTACK-197 Diffs * awsapi/src/com/cloud/bridge/service/EC2RestServlet.java (4f74873) View Diff<https://reviews.apache.org/r/8468/diff/>
