----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8578/#review14511 -----------------------------------------------------------
Breaks build, patch does not have Validator.java, can you share that as another patch or file? - Rohit Yadav On Dec. 14, 2012, 3:30 a.m., Fang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8578/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2012, 3:30 a.m.) > > > Review request for cloudstack and Rohit Yadav. > > > Description > ------- > > Add the entity handling in apiDisptacher; in genericDao, add findByXid(); > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-518. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/response/DomainResponse.java e97653b > api/src/org/apache/cloudstack/api/response/UserVmResponse.java 4934d8b > server/src/com/cloud/api/ApiDispatcher.java 37321a1 > server/src/com/cloud/api/ApiServer.java 183249f > server/src/com/cloud/dao/EntityManagerImpl.java 1430c08 > utils/src/com/cloud/utils/db/GenericDao.java f36c4d8 > utils/src/com/cloud/utils/db/GenericDaoBase.java be0fe89 > > Diff: https://reviews.apache.org/r/8578/diff/ > > > Testing > ------- > > > Thanks, > > Fang Wang > >
