----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8578/#review14512 -----------------------------------------------------------
Thanks, work in progress. Holding onto the previous patch but committed Validator on api_refactoring: commit 44ef998cfc83bcb210cf257bd137073338aab4e2 Author: Fang Wang <[email protected]> Date: Fri Dec 14 11:42:49 2012 -0800 api: Add Validator interface that will be used for the @Validator annotation The @Validator (defined as @validate in wiki/FS) will do the following things: - DBEntityValidator (verifies if the entity exists in the db or not) - RangeValidator (min, max; limits) - Rohit Yadav On Dec. 14, 2012, 7:09 p.m., Fang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8578/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2012, 7:09 p.m.) > > > Review request for cloudstack and Rohit Yadav. > > > Description > ------- > > Add the entity handling in apiDisptacher; in genericDao, add findByXid(); > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-518. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/response/DomainResponse.java e97653b > api/src/org/apache/cloudstack/api/response/UserVmResponse.java 4934d8b > server/src/com/cloud/api/ApiDispatcher.java 37321a1 > server/src/com/cloud/api/ApiServer.java 183249f > server/src/com/cloud/dao/EntityManagerImpl.java 1430c08 > utils/src/com/cloud/utils/db/GenericDao.java f36c4d8 > utils/src/com/cloud/utils/db/GenericDaoBase.java be0fe89 > > Diff: https://reviews.apache.org/r/8578/diff/ > > > Testing > ------- > > > Thanks, > > Fang Wang > >
