Is the actual merging a manual process at this point? In such case, consider this email a gentle poke to the committers. If not, consider this a proto-bugreport :)
/n On Sun, Jan 6, 2013 at 12:22 AM, Rohit Yadav <bhais...@apache.org> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8836/#review15094 > ----------------------------------------------------------- > > Ship it! > > > Mentioning parent version is enough, it's good. > Thanks. Ship It! > > - Rohit Yadav > > > On Jan. 4, 2013, 10:37 p.m., Noa Resare wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/8836/ > > ----------------------------------------------------------- > > > > (Updated Jan. 4, 2013, 10:37 p.m.) > > > > > > Review request for cloudstack. > > > > > > Description > > ------- > > > > I'm playing around with nonstandard artifact versions in maven, and > found two module pom files: > > > > plugins/hypervisors/simulator/pom.xml > > plugins/network-elements/dns-notifier/pom.xml > > > > that explicitly set's their versions. This is not needed, as they are > only used as submodules of the toplevel pom.xml and as such they inherit > the version of the toplevel project if the version element is absent. > > > > The attached patch removes the redundant version information. > > > > > > This addresses bug CLOUDSTACK-790. > > > > > > Diffs > > ----- > > > > plugins/hypervisors/simulator/pom.xml 15b3790 > > plugins/network-elements/dns-notifier/pom.xml 0b4c981 > > > > Diff: https://reviews.apache.org/r/8836/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Noa Resare > > > > > > -- Engineering Experience, Infrastructure tribe, Spotify
