-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8836/#review15172
-----------------------------------------------------------

Ship it!


Applied on master:

commit 4f98d879f69bdddca74e56a21c06df9b033d049a
Author: Noa Resare <n...@spotify.com>
Date:   Tue Jan 8 20:25:58 2013 -0800

    maven: remove explicit submodule versions from module pom.xml
    


- Rohit Yadav


On Jan. 4, 2013, 10:37 p.m., Noa Resare wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8836/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 10:37 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> I'm playing around with nonstandard artifact versions in maven, and found two 
> module pom files: 
> 
> plugins/hypervisors/simulator/pom.xml 
> plugins/network-elements/dns-notifier/pom.xml 
> 
> that explicitly set's their versions. This is not needed, as they are only 
> used as submodules of the toplevel pom.xml and as such they inherit the 
> version of the toplevel project if the version element is absent. 
> 
> The attached patch removes the redundant version information.
> 
> 
> This addresses bug CLOUDSTACK-790.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/simulator/pom.xml 15b3790 
>   plugins/network-elements/dns-notifier/pom.xml 0b4c981 
> 
> Diff: https://reviews.apache.org/r/8836/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Noa Resare
> 
>

Reply via email to