-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9241/#review16009
-----------------------------------------------------------


Can you perhaps find out if there's something you can do to tell the VM that 
the disk size has changed? For instance with KVM/qemu we have to send libvirt a 
volBlockResize command so that it actually changes the live system. Or perhaps 
you just have to rescan the scsi controller inside the vm. If online resize 
doesn't work at all, there's code in resizeVolume you can use to only support 
offline resize (checks that the VM is stopped, used by Xen).

- Marcus Sorensen


On Feb. 1, 2013, 9:23 a.m., Hongtu Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9241/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 9:23 a.m.)
> 
> 
> Review request for cloudstack, mice xia and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> add vmware resizeVolume support
> 
> 
> This addresses bug CLOUDSTACK-644.
> 
> 
> Diffs
> -----
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  dd917f7 
>   server/src/com/cloud/storage/StorageManagerImpl.java 07f4d8a 
> 
> Diff: https://reviews.apache.org/r/9241/diff/
> 
> 
> Testing
> -------
> 
> Start a vm using builtin template [CentOS 5.3(64-bit) no GUI (vSphere)].
> Attach two data volumes, one made by disk_offering "Small", another made by 
> "Custom".
> Try to resize the two volumes when vm in running or stopped state.
> After the api finished resize the volume, we found the size changed in the 
> vSphere Client while the size in system is not changed. Reboot the vm and use 
> fdisk to check the disk size, we found the size is changed.
> 
> If we try to shrink the volume, the vsphere will throw an exception, I add a 
> check in the code before resize volume. If the newSize is smaller, it will 
> return false.
> 
> 
> Thanks,
> 
> Hongtu Zang
> 
>

Reply via email to