> On Feb. 1, 2013, 9:41 a.m., Sateesh Chodapuneedi wrote: > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java, > > line 518 > > <https://reviews.apache.org/r/9241/diff/1/?file=254592#file254592line518> > > > > Are we checking for newSize equal to oldSize before arriving at this > > code? If not we can do the check here and return ResizeVolumeAnswer(cmd, > > true, "success")
We aren't checking it in the StorageManagerImpl.java. On some level it might make sense to, but if we don't then people could use this to do something like migrate to a custom disk offering without actually changing the disk size, then resize later by simply providing a size rather than a new disk offering. He could also check if shrinkOk is true, since he wouldn't get here if newSize < oldSize and shrinkOk is false. - Marcus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9241/#review15998 ----------------------------------------------------------- On Feb. 2, 2013, 12:59 a.m., Hongtu Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9241/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2013, 12:59 a.m.) > > > Review request for cloudstack, mice xia and Marcus Sorensen. > > > Description > ------- > > add vmware resizeVolume support > > > This addresses bug CLOUDSTACK-644. > > > Diffs > ----- > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > dd917f7 > server/src/com/cloud/storage/StorageManagerImpl.java 07f4d8a > > Diff: https://reviews.apache.org/r/9241/diff/ > > > Testing > ------- > > Start a vm using builtin template [CentOS 5.3(64-bit) no GUI (vSphere)]. > Attach two data volumes, one made by disk_offering "Small", another made by > "Custom". > Try to resize the two volumes when vm in running or stopped state. > After the api finished resize the volume, we found the size changed in the > vSphere Client while the size in system is not changed. Reboot the vm and use > fdisk to check the disk size, we found the size is changed. > > If we try to shrink the volume, the vsphere will throw an exception, I add a > check in the code before resize volume. If the newSize is smaller, it will > return false. > > > Thanks, > > Hongtu Zang > >
