----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9143/#review16140 -----------------------------------------------------------
I got a bit curious about this code when I read about the licensing uncertainty on the mailing list. Looking at it I have two questions to begin with: What version of the cloudstack tree does this patch apply cleanly onto? It does not seem like the python code even attempts to adhere to pep8 as perscribed by http://incubator.apache.org/cloudstack/develop/coding-conventions.html Why is that? - Noa Resare On Jan. 29, 2013, 9:43 p.m., Donal Lafferty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9143/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 9:43 p.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > To include Hyper-V plugin in a build, add '-DhyperV' to the mvn options. > E.g. mvn clean install -DhyperV > > Overview https://cwiki.apache.org/CLOUDSTACK/hyper-v-2012-30-support.html > > tl;dr: First cut of HyperV plugin, cloud-api changes to support VHDX image > type, and test changes to deal with Windows clock accuracy and URI semantics. > > > This addresses bug CLOUDSTACK-999. > > > Diffs > ----- > > agent/conf/agent.properties 74cfd1c21d6b2910be3859b4f570feee3ba172d5 > agent/conf/log4j-cloud.xml PRE-CREATION > agent/src/com/cloud/agent/AgentShell.java > e3d1063e6b8c148d765c2b185896ead2091769b3 > agent/src/com/cloud/agent/resource/DummyResource.java > 573f639b06d92db614e0cc60eee63d94d1160426 > agent/test/com/cloud/agent/TestAgentShell.java > d7210acbef30044e86d734c31bea870381653557 > api/src/com/cloud/storage/Storage.java > fba12b62d3d5205ff32ab2f67065b45d011bcb05 > client/pom.xml 7ebe50c48f9a692fc610871cfdb21c12370afd3a > client/tomcatconf/components.xml.in > c41d4f4f18f3a505ea97a032d348718a915bbf10 > core/src/com/cloud/hypervisor/hyperv/resource/HypervDummyResourceBase.java > 6e52924db28bf9dc4749287d2ccbb7836b6d55e3 > core/src/com/cloud/hypervisor/hyperv/resource/HypervResource.java > ede6301d9c354f69a3a9db85830d0d0d87008495 > > plugins/api/rate-limit/test/org/apache/cloudstack/ratelimit/ApiRateLimitTest.java > 502b15cf316374104ff64eb5c7f3b9026303efc5 > plugins/hypervisors/hyperv/conf/agent.properties PRE-CREATION > plugins/hypervisors/hyperv/conf/developer.properties.template PRE-CREATION > plugins/hypervisors/hyperv/conf/environment.properties.in PRE-CREATION > plugins/hypervisors/hyperv/conf/log4j-cloud.xml PRE-CREATION > plugins/hypervisors/hyperv/conf/log4j-cloud.xml.in PRE-CREATION > plugins/hypervisors/hyperv/pom.xml PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/.pydevproject PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/baseops.py PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/cloudstackcmds.py PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/constants.py PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/hypervlog.conf PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/log.py PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/power_state.py PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/vmops.py PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/vmutils.py PRE-CREATION > plugins/hypervisors/hyperv/scripts/hyperv/volumeops.py PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/guru/HypervGuru.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDummyResourceBase.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervResource.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/PythonUtils.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/storage/HypervPhysicalDisk.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/storage/HypervStoragePool.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/storage/HypervStoragePoolManager.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/storage/StorageAdaptor.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/storage/WindowsStorageAdaptor.java > PRE-CREATION > > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/storage/WindowsStoragePool.java > PRE-CREATION > > plugins/hypervisors/hyperv/test/com/cloud/hypervisor/hyperv/test/HypervResourceTest.java > PRE-CREATION > plugins/pom.xml 7bb60a990fbb3d65f514e8b53155162a61602a33 > server/src/com/cloud/configuration/Config.java > 4ae144e6ce116b34f6a62b9bdfc5f9262984a448 > server/src/com/cloud/hypervisor/guru/HypervGuru.java > 1d59afd93a7a6e989e49548741de263ad6626baf > server/src/com/cloud/hypervisor/hyperv/HypervServerDiscoverer.java > 6a1cd67d8f3d3b5d2ce99fae15ee58a9583795a2 > server/src/com/cloud/resource/ResourceManagerImpl.java > f82424a10c25aa7cd51acaed5744242c885920ee > server/src/com/cloud/storage/StorageManagerImpl.java > 07f4d8ac7cb3dcf7dbb57baf473dbe7b5f597b7b > server/src/com/cloud/template/HyervisorTemplateAdapter.java > c80d1de0fbf1f7b58c5526ad7e3744ed382f0017 > ui/scripts/templates.js 040ce4a92c145c7f79c474b7b722be1d019c42a7 > > Diff: https://reviews.apache.org/r/9143/diff/ > > > Testing > ------- > > > Thanks, > > Donal Lafferty > >
