Yes, leave it out of the UI for now On 2/15/13 8:14 AM, "Donal Lafferty" <donal.laffe...@citrix.com> wrote:
> > >> On Feb. 14, 2013, 7:21 p.m., Chiradeep Vittal wrote: >> > I feel this should part of a patch set. On its own the patch doesn't >>make sense: users will see a way to register a VHDX template but with no >>way to use it. >> > Can you submit it with the rest of the Hyper-v features ? > >My feelings exactly, but this issue is far broader that the Hyper-V >plugin. > >What you've identified is a problem with the plugin architecture: >plugins cannot specify UI changes. Clearly, the UI should not indicate >Hyper-V support unless a working plugin is available, but that's not how >CloudStack is designed. There's no way to add or disable GUI changes >required for optional plugins like Hyper-V Phase 1. > >That said, we are where we are. > >Would it be possible to revise the diff to include all Hyper-V plugin >files with Apache-licensed code but remove any UI code that appears to >the user? I am concerned that any code refactoring include the work that >I've done. > > >- Donal > > >----------------------------------------------------------- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/9444/#review16599 >----------------------------------------------------------- > > >On Feb. 14, 2013, 1:52 p.m., Donal Lafferty wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/9444/ >> ----------------------------------------------------------- >> >> (Updated Feb. 14, 2013, 1:52 p.m.) >> >> >> Review request for cloudstack and Animesh Chaturvedi. >> >> >> Description >> ------- >> >> Add support for VHDX image type, and allow UI for RegisterTemplate to >>support both Hyper-V image types. >> >> >> This addresses bug >>https://issues.apache.org/jira/browse/CLOUDSTACK-1032. >> >> >> Diffs >> ----- >> >> api/src/com/cloud/storage/Storage.java fba12b6 >> server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe >> server/src/com/cloud/template/HyervisorTemplateAdapter.java 089f650 >> ui/scripts/templates.js 040ce4a >> >> Diff: https://reviews.apache.org/r/9444/diff/ >> >> >> Testing >> ------- >> >> Integration test on code when built for Hyper-V Phase 1 fork. >> >> Not clear what unit tests can be updated to walk the code. >> >> >> Thanks, >> >> Donal Lafferty >> >> >
