----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9444/#review17152 -----------------------------------------------------------
I think this review was useful to get feedback on the code itself, but we don't want to apply the patch as-is. Chiradeep's comments explain why. Can we please close this review out now as discarded (until Hyper-V is brought into the project)? - Chip Childers On Feb. 20, 2013, 7:52 p.m., Donal Lafferty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9444/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2013, 7:52 p.m.) > > > Review request for cloudstack, Chiradeep Vittal and Animesh Chaturvedi. > > > Description > ------- > > Add support for VHDX image type, and allow UI for RegisterTemplate to support > both Hyper-V image types. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1032. > > > Diffs > ----- > > api/src/com/cloud/storage/Storage.java fba12b6 > server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe > server/src/com/cloud/template/HyervisorTemplateAdapter.java 089f650 > ui/scripts/templates.js 040ce4a > > Diff: https://reviews.apache.org/r/9444/diff/ > > > Testing > ------- > > Integration test on code when built for Hyper-V Phase 1 fork. > > Not clear what unit tests can be updated to walk the code. > > > Thanks, > > Donal Lafferty > >
