----- Original Message ----- > On Wed, Feb 10, 2016 at 01:55:26PM -0500, Bob Peterson wrote: > > I've been doing a bunch of recovery testing with DLM and discovered some > > issues. This collection of 6 patches addresses those issues. Some of them > > are of my own making, introduced by the recent patches that made DLM > > print socket connection errors, and recovery from those errors. > > Thanks Bob, perhaps I've not been paying close enough attention, but it's > unclear to me how this patch set relates the the most accute issue we have > at the moment, which are the problems introduced here: > > From b3a5bbfd780d9e9291f5f257be06e9ad6db11657 Mon Sep 17 00:00:00 2001 > From: Bob Peterson <rpete...@redhat.com> > Date: Thu, 27 Aug 2015 09:34:47 -0500 > Subject: [PATCH] dlm: print error from kernel_sendpage > > Print a dlm-specific error when a socket error occurs > when sending a dlm message. > > Signed-off-by: Bob Peterson <rpete...@redhat.com> > Signed-off-by: David Teigland <teigl...@redhat.com> > > Could we begin with one patch that's easy to track that directly resolves > the issues with that commit (perhaps even a revert if it's not simple to > fix directly)? That brings us back to a known-good place, from which we > can look at cleanups and changes. > Hi Dave,
My goal has always been to attain stability, which I think I've finally achieved. The problem is: While testing the dlm in multiple recovery situations, Nate and I discovered multiple problems. Until recently, no one has tried to run recovery tests on an upstream DLM, so I think we're finding some old bugs that have been there for a while, as well as bugs with b3a5bbfd, which you mentioned. I agree that some of these patches might be unnecessary improvements. I'll try to pare them down to what is absolutely necessary and what is not. I'll also document exactly why the necessary ones are needed. I'll also try to post them in order of highest priority and repost them as individual patches rather than a set. The recovery tests are somewhat slow, so this will take some time. BTW, Have you had a chance to look at the patch I posted on 18 January, titled "DLM: Replace nodeid_to_addr with kernel_getpeername"? That definitely fixes one bug in patch b3a5bbfd which you mentioned. I assume you're not suggesting I combine that patch with other patches to stabilize b3a5bbfd, right? As you well know, this is very touchy code and it's easier to diagnose and debug a larger number of smaller patches. Regards, Bob Peterson Red Hat File Systems
