On Thu, Nov 15, 2018 at 04:52:58PM +0800, Ming Lei wrote: > bch_bio_alloc_pages() is always called on one new bio, so it is safe > to access the bvec table directly. Given it is the only kind of this > case, open code the bvec table access since bio_for_each_segment_all() > will be changed to support for iterating over multipage bvec. > > Cc: Dave Chinner <[email protected]> > Cc: Kent Overstreet <[email protected]> > Acked-by: Coly Li <[email protected]> > Cc: Mike Snitzer <[email protected]> > Cc: [email protected] > Cc: Alexander Viro <[email protected]> > Cc: [email protected] > Cc: Shaohua Li <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: David Sterba <[email protected]> > Cc: [email protected] > Cc: Darrick J. Wong <[email protected]> > Cc: [email protected] > Cc: Gao Xiang <[email protected]> > Cc: Christoph Hellwig <[email protected]> > Cc: Theodore Ts'o <[email protected]> > Cc: [email protected] > Cc: Coly Li <[email protected]> > Cc: [email protected] > Cc: Boaz Harrosh <[email protected]> > Cc: Bob Peterson <[email protected]> > Cc: [email protected] > Signed-off-by: Ming Lei <[email protected]> > --- > drivers/md/bcache/util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/util.c b/drivers/md/bcache/util.c > index 20eddeac1531..8517aebcda2d 100644 > --- a/drivers/md/bcache/util.c > +++ b/drivers/md/bcache/util.c > @@ -270,7 +270,7 @@ int bch_bio_alloc_pages(struct bio *bio, gfp_t gfp_mask) > int i; > struct bio_vec *bv; > > - bio_for_each_segment_all(bv, bio, i) { > + for (i = 0, bv = bio->bi_io_vec; i < bio->bi_vcnt; bv++) {
This is missing an i++.
