Hi Steve, ----- Original Message ----- > > > On 19/11/18 13:29, Bob Peterson wrote: > > This is another baby step toward a better glock state machine. > > Before this patch, do_xmote was called with a gh parameter, but > > only for promotes, not demotes. This patch allows do_xmote to > > determine the gh autonomously. > > > > Signed-off-by: Bob Peterson <rpete...@redhat.com>
(snip) > Since gh is apparently only used to get the lock flags, it would make > more sense just to pass the lock flags rather than add in an additional > find_first_waiter() call, > > Steve. Perhaps I didn't put enough info into the comments for this patch. I need to get rid of the gh parameter in order to make the glock state machine fully autonomous. In other words, function do_xmote will become a state in the (stand alone) state machine, which itself does not require a gh parameter and may be called from several places under several conditions. The state of the glock will determine that it needs to call do_xmote, but do_xmote needs to figure it out on its own. Before this patch, the caller does indeed know the gh pointer, but in the future, it will replaced by a generic call to the state machine which will not know it. Regards, Bob Peterson
