[Cluster-devel] [PATCH v10 03/25] mm: Ignore return value of ->readpages

[Matthew Wilcox]

From: "Matthew Wilcox (Oracle)" <wi...@infradead.org>

We used to assign the return value to a variable, which we then ignored.
Remove the pretence of caring.

Signed-off-by: Matthew Wilcox (Oracle) <wi...@infradead.org>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Reviewed-by: Dave Chinner <dchin...@redhat.com>
Reviewed-by: John Hubbard <jhubb...@nvidia.com>
Reviewed-by: William Kucharski <william.kuchar...@oracle.com>
---
 mm/readahead.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/mm/readahead.c b/mm/readahead.c
index 41a592886da7..61b15b6b9e72 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -113,17 +113,16 @@ int read_cache_pages(struct address_space *mapping, 
struct list_head *pages,
 
 EXPORT_SYMBOL(read_cache_pages);
 
-static int read_pages(struct address_space *mapping, struct file *filp,
+static void read_pages(struct address_space *mapping, struct file *filp,
                struct list_head *pages, unsigned int nr_pages, gfp_t gfp)
 {
        struct blk_plug plug;
        unsigned page_idx;
-       int ret;
 
        blk_start_plug(&plug);
 
        if (mapping->a_ops->readpages) {
-               ret = mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
+               mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
                /* Clean up the remaining pages */
                put_pages_list(pages);
                goto out;
@@ -136,12 +135,9 @@ static int read_pages(struct address_space *mapping, 
struct file *filp,
                        mapping->a_ops->readpage(filp, page);
                put_page(page);
        }
-       ret = 0;
 
 out:
        blk_finish_plug(&plug);
-
-       return ret;
 }
 
 /*
-- 
2.25.1