From: "Matthew Wilcox (Oracle)" <wi...@infradead.org>

Change the type of page_idx to unsigned long, and rename it -- it's
just a loop counter, not a page index.

Suggested-by: John Hubbard <jhubb...@nvidia.com>
Signed-off-by: Matthew Wilcox (Oracle) <wi...@infradead.org>
Reviewed-by: Dave Chinner <dchin...@redhat.com>
Reviewed-by: William Kucharski <william.kuchar...@oracle.com>
---
 mm/readahead.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/readahead.c b/mm/readahead.c
index 8a65d6bd97e0..7ce320854bad 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -163,13 +163,13 @@ void __do_page_cache_readahead(struct address_space 
*mapping,
        struct page *page;
        unsigned long end_index;        /* The last page we want to read */
        LIST_HEAD(page_pool);
-       int page_idx;
        loff_t isize = i_size_read(inode);
        gfp_t gfp_mask = readahead_gfp_mask(mapping);
        struct readahead_control rac = {
                .mapping = mapping,
                .file = filp,
        };
+       unsigned long i;
 
        if (isize == 0)
                return;
@@ -179,8 +179,8 @@ void __do_page_cache_readahead(struct address_space 
*mapping,
        /*
         * Preallocate as many pages as we will need.
         */
-       for (page_idx = 0; page_idx < nr_to_read; page_idx++) {
-               pgoff_t page_offset = index + page_idx;
+       for (i = 0; i < nr_to_read; i++) {
+               pgoff_t page_offset = index + i;
 
                if (page_offset > end_index)
                        break;
@@ -201,7 +201,7 @@ void __do_page_cache_readahead(struct address_space 
*mapping,
                        break;
                page->index = page_offset;
                list_add(&page->lru, &page_pool);
-               if (page_idx == nr_to_read - lookahead_size)
+               if (i == nr_to_read - lookahead_size)
                        SetPageReadahead(page);
                rac._nr_pages++;
        }
-- 
2.25.1


Reply via email to