On 06/03/2015 04:35 PM, Davy Durham wrote: > Okay, here's my patch. It worked on my system. I tested with the > versions I have installed: VS 2008 and VS 2013, and it worked great. > > Fairly simple. Updated the docs [sufficiently, I think].
That looks pretty good. A few comments: * Please provide a proposed commit message. The first line should end with (#15578) to reference the issue tracker entry. * Please wrap lines in C++ sources to <= 79 columns. * Please use "this->" for references to member variables (e.g. this->FirstProject). * Please look at adding a test case, perhaps as a new case in "Tests/RunCMake/SolutionGlobalSections/RunCMakeTest.cmake". That test already has code to parse the generated solution. You can parse it to verify the desired project is first (and perhaps a second case to verify ALL_BUILD is the default). Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
