On 03/18/2016 12:38 PM, Taylor Braun-Jones wrote:
> Here's Davy's patch rebased against current master with a unit test
> added. Tested on Visual Studio 2013 only. Let me know if I screwed up
> the rebase. Some conflicts weren't totally obvious to me how to
> handle.

Thanks!

I decided to rename the existing test first:

 Tests: Rename RunCMake.{SolutionGlobalSections => VSSolution}
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5c1f4da8

Then I applied the change with some minor fixups:

 VS: Add option to choose the `.sln` startup project (#15578)
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cdfd837a

The main difference is that we now check that the named target
exists.  If not we warn and ignore the property.  I added a test
for that too.

Please check that the revised version works for you.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to