On Tue, Apr 5, 2011 at 5:33 AM, Brad King <brad.k...@kitware.com> wrote: > On 04/04/2011 12:01 PM, Manuel Klimek wrote: >> Done. > > Thanks! > >> I also have the previous patches ready (re-based with master). Let me >> know how we'll go on about submitting all that. > > I still have them on a local topic branch. See below. > Have you changed anything since then?
Well, the git rebase led to conflicts which I resolved - otherwise I didn't change anything on the other patches. So I can re-export the changes to save you some work with merging, if you want :) Cheers, /Manuel > If you prefer to send the new versions, please use "git format-patch" to > construct the patch series. Then send the files by email. > > Thanks, > -Brad > > > commit c8ed16a373adf98cf21a619349de8c0bde6a0eed > Author: Manuel Klimek <kli...@google.com> > Date: Mon Jan 17 11:44:44 2011 -0500 > > Make compile line export optional > > Add option CMAKE_EXPORT_COMPILE_COMMANDS to control the behavior. > > Modules/CMakeGenericSystem.cmake | 3 +++ > Source/cmGlobalUnixMakefileGenerator3.cxx | 2 +- > Source/cmMakefileTargetGenerator.cxx | 3 ++- > 3 files changed, 6 insertions(+), 2 deletions(-) > > commit 357fdbb1d7c472991323d36c6a431a36f16918bd > Author: Manuel Klimek <kli...@google.com> > Date: Thu Jan 13 16:15:54 2011 -0500 > > Export all compile command lines to json database > > Source/cmGlobalUnixMakefileGenerator3.cxx | 41 > +++++++++++++++++++++++++++++ > Source/cmGlobalUnixMakefileGenerator3.h | 6 ++++ > Source/cmMakefileTargetGenerator.cxx | 21 +++++++++++++- > 3 files changed, 66 insertions(+), 2 deletions(-) > > commit a75e21cadeb48c257d870db925131994f7da4995 > Author: Manuel Klimek <kli...@google.com> > Date: Thu Jan 13 16:06:20 2011 -0500 > > Factor Makefile flag and define lookup into methods > > Cache results over repeated calls. > > Source/cmMakefileTargetGenerator.cxx | 107 +++++++++++++++++++-------------- > Source/cmMakefileTargetGenerator.h | 5 ++ > 2 files changed, 67 insertions(+), 45 deletions(-) > -- Manuel Klimek (http://go/klimek) _______________________________________________ cmake-developers mailing list cmake-developers@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
