Stephen Kelly wrote: > Brad King wrote: > >> On 11/30/2011 9:09 AM, Stephen Kelly wrote: >>> Brad King wrote: >>>> Alex was proposing simply to provide the singular name as a variable >>>> but not >>>> to cache it. The only reason to cache a variable is when we're >>>> searching and >>>> need to let the user help out or override. In a Config.cmake file we >>>> know the answer. >>> >>> Ok, so you're saying the user should definitely not be able to override >>> the value, so it shouldn't be cached. The remaining question is whether >>> it should be provided anyway uncached for the reasons Alex described. If >>> that should be done, then I can do that. >> >> I don't mind providing it for convenience. However more variables means >> more variables. Users may not know which one to use when. I don't have >> a strong opinion either way. > > Ok, my opinion is to provide one variable in plural form for now. If there > is a reason to provide a singular form, we can add that later. Let's just > see what Alex and CLinton say before I do that.
I've submitted patches now to remove unneeded variables, pluralize the remaining, and use Qt5::Core style for the targets. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
