On Thu, Feb 9, 2012 at 3:45 PM, Alexander Neundorf <[email protected]> wrote:
> On Monday 30 January 2012, Stephen Kelly wrote: > > David Cole wrote: > > > On Sun, Jan 29, 2012 at 11:44 AM, Stephen Kelly > > > > > > <[email protected]> wrote: > > >> David Cole wrote: > > >>> OK... nearly complete now. Please review, then reply and tell me if > > >>> you object to any of the 7 commits in this topic branch. > > >> > > >> No objections. They all seem fine. > > > > > > Great, thanks. > > > > > >>> Steve, I've > > >>> preserved your authorship for most of these commits, but have > > >>> significantly re-written some of them. > > >> > > >> The 3 following 073bc421620e25fef6389b0d8b71cfad8ca79786 (CMake: > > >> Eliminate cmMakefile::IncludeDirectories) seem to have been > > >> substantially re-written. I'm not sure what is the appropriate way to > > >> deal with commits like that, but whatever you choose for the author > > >> line is fine. > > > > > > So I guess the question is: if somebody looks up the author at some > > > point in the future and comes asking a question, do you want to be the > > > one they go to, or would you rather have them come to me? ;-) If you > > > want to send them to me, I'll change the author line, but you > > > certainly deserve the credit for getting the ball rolling on this > > > topic. > > > > Ok, let's leave it as-is and I'll take responsibility (blame/credit) :) > > > > <snip> > > > > >>> - double-check with Alex about the changes in cmake::FindPackage -- > > >>> Alex? > > > > Still pending. > > Sorry that it took so long, I was really busy the last few weeks. > > I cloned this repo: git clone https://github.com/dlrdave/CMake.git > > Both the Eclipse generator and cmake --find-package work fine. > Excellent : thanks very much for trying it out. I'll try to get this first draft merged to 'next' tonight or tomorrow. > > Just to make completely sure: the purpose of this target property is *not* > that targets linking against a library with this property set should reuse > these include dirs, right ? > > Nevertheless, did you already think about how the interface for such a > feature > could look like (to make sure it fits with this new target property) ? > Maybe something like this ? > set_target_properties(... PROPERTIES > INCLUDE_DIRECTORIES a/ b/ c/ > PUBLIC_BUILD_INCLUDE_DIRECTORIES d/ e/ f/ > PUBLIC_INSTALL_INCLUDE_DIRECTORIES g/ h/ i/ ) > > It would have to be possible to separate between include dirs to be used at > build time of the library, and include dirs to be used once the library has > been installed (similar to the build and install RPATH) > > ...just to make sure the syntax for the new INCLUDE_DIRECTORIES property > is ok > and doesn't make problems later on. > > Alex > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers >
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
