On Wed, Feb 22, 2012 at 3:04 PM, David Cole <david.c...@kitware.com> wrote: > On Wed, Feb 22, 2012 at 8:05 AM, David Cole <david.c...@kitware.com> wrote: >> On Thu, Feb 16, 2012 at 4:11 PM, Stephen Kelly <steve...@gmail.com> wrote: >>> David Cole wrote: >>> >>>> Pushed down the queue again... I'll get to it soon. There are a handful of >>>> minor changes that I still need to make first. >>> >>> Ok. >>> >>> Let me know if it's anything I can do. >>> >>> Thanks, >>> >>> Steve. >>> >>> >>> -- >>> >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Please keep messages on-topic and check the CMake FAQ at: >>> http://www.cmake.org/Wiki/CMake_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers >> >> >> Finally pushed the most recent commits this morning... Please see the >> target-include-directories branch on the stage. (Not yet merged to >> 'next' -- but soon will be.) >> >> >> Question (probably for Brad): >> >> What should --help-property emit now that there are both directory and >> target level properties for INCLUDE_DIRECTORIES? >> >> Here's what it does: >> >> $ bin/Debug/cmake --help-property INCLUDE_DIRECTORIES >> cmake version 2.8.7.20120222-g56a44 >> INCLUDE_DIRECTORIES >> List of preprocessor include file search directories. >> >> This read-only property specifies the list of directories given so far >> to the include_directories command. It is intended for debugging >> purposes. >> >> So the most recent commit in the topic branch, which adds >> documentation for the target level property, appears useless... Should >> we eliminate the directory level documentation as well? Or emit both? >> If so, how? >> >> After we settle this one remaining point, I'll patch up the topic >> branch and merge it to 'next'. >> >> Thanks to everybody for your help and patience in getting this feature >> into CMake. >> >> >> Cheers, >> David C. > > > Finally ready... > > I just force-pushed the 'target-include-directories' branch to stage > again. I think it's ready for merging to 'next' -- before I do that, > could I get a sanity check that the documentation in the top commit > (ff44b88) is acceptable? > > > Thanks, > David
All set. One more force-push after cleaning up a commit on Brad's recommendation and .... it is now finally merged to 'next'. Whew. Thx, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers