On Fri, Apr 6, 2012 at 3:49 PM, David Cole <[email protected]> wrote: > On Fri, Apr 6, 2012 at 3:10 PM, Peter Kümmel <[email protected]> wrote: >> >>> One nitpick with the patch, the KWStyle test fails because lines 58& >>> 63 exceed our max line length limit (79 characters is the max). Could >>> you please put another commit on top of that one, fixing the lines >>> that are too long, and then also push that to stage and merge it to >>> next again? >> >> >> 79 limit... >> couldn't resist when typing the commit message ;) >> > > > Yes, I don't blame you. I've had the same thought myself several > hundred times. ;-) > > Thanks a bunch. It prevents a big red splotch on the dashboard tomorrow. > > > David
Despite fixing up the line length issue... there are several new ninja-related dashboard problems today after your commits from yesterday. Please take a look at them here: http://open.cdash.org/index.php?project=CMake and see what you can do to patch them up. There's one new compiler warning, and it looks like your CMakeLists changes have somehow caused a massive failure of the test suite. I'm not sure I understand why yet, but perhaps you could try running the test suite on your end, too, on a Mac or Windows build? Thx, David -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
