----- Original Message -----
> Clinton,
> 
> On 07/17/2013 01:07 AM, Clinton Stimpson wrote:
> > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=90993b9016abf241cd0a4de71e76eb738202c136
> > commit 90993b9016abf241cd0a4de71e76eb738202c136
> > Author:     Clinton Stimpson <[email protected]>
> > AuthorDate: Tue Jul 16 23:01:50 2013 -0600
> > Commit:     Clinton Stimpson <[email protected]>
> > CommitDate: Tue Jul 16 23:05:28 2013 -0600
> > 
> >     ninja, OS X: fix regression handling frameworks
> >     
> >     Since the ninja file isn't aware of how framework symlinks work,
> >     we suppress symlink creation and let cmOSXBundleGenerator handle it.
> >     Also, use the real name of framework library in build rules as was done
> >     before,
> >     instead of the symlink.
> 
> Should this be squashed into its parent or is this fixing a regression
> that was introduced earlier and exposed by the parent commit?  If the
> latter, please update the commit message to explain when the regression
> was introduced since it is already in master.
> 
> Thanks,
> -Brad
> 

It exposed a regression in a parent commit.  I've updating the commit message 
to give the parent commit with the regression.

Clint
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to