On Wed, Jul 24, 2013 at 7:56 PM, Nicolas Desprès <nicolas.desp...@gmail.com>wrote:
> > > > On Wed, Jul 24, 2013 at 12:18 PM, Stephen Kelly <steve...@gmail.com>wrote: > >> Nicolas Desprès wrote: >> >> >> > That's said we can optimize further as I mentioned in my comment ( >> >> > >> >> >> >> >> >> https://github.com/nicolasdespres/CMake/commit/59c871da8b00554812e93ba9c6e47d864424efb0#L0R2023 >> >> ). >> >> > Do you have an opinion about it? >> >> >> >> Do I understand correctly that the issue is that OutputToSource values >> >> can be absolute or relative paths? That would be fixable by patching >> only >> >> UpdateOutputToSourceMap, right? >> >> >> > Not exactly. According to my tests only >> > cmMakefiles::GetSourceFileWithOutput's cname argument can be either >> > relative or absolute. >> >> Then patching the callers of GetSourceFileWithOutput is worth looking >> into. >> There are not many. You'd have to try it and see if any issues come up. >> >> Ok. I will give it a try tomorrow. I hope it won't bring in part of CMake > I do not know. > > Hi Stephen, I think I need your insight of CMake code base here. According to my tests (ie ExportImport and CustomCommand), GetSourceFileWithOutput() is called with a relative path only from here: https://github.com/Kitware/CMake/blob/master/Source/cmTarget.cxx#L1939 How can I convert this name to an absolute path? Cheers, -- Nicolas Desprès
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
