On 08/05/2013 11:28 AM, Nicolas Desprès wrote: > I have just rebased my branch on top of the master and the test suite still > pass. [snip] > I really want to have this patch in the next release
I can't promise to accept it since 2.8.12 rc1 is coming out tomorrow or Wednesday and this topic isn't even in 'next' yet. This touches some pretty fundamental logic and could easily have a subtle behavior change so I consider it high risk. On 07/29/2013 08:25 AM, Stephen Kelly wrote: > I think Brad will have to do the rest. Sorry, I stopped reading this thread assuming that it would end with Steve bringing the change to the topic stage at which point my attention would be drawn again. I just fetched the large-deps-perf topic from your Github repo. I've never been happy with the linear search so thanks for working on this. Here are a couple comments: * Please replace large_list.cmake in the test with use of the foreach() command's RANGE signature and list(APPEND). * Why is special logic in Tests/CMakeLists.txt needed to add the test case? * Please add comments explaining in prose what the lookup map comparison functor is doing and why. I could infer it only by looking at the old code (which should have been commented before too). The assert examples are good for verification but not for understanding from scratch. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
