On 08/06/2013 12:44 PM, Brad King wrote:
> On 08/06/2013 12:18 PM, Nicolas Desprès wrote:
>> The test suite passes on my computer. I have force-pushed again.
> 
> Great.

I had to modify the test like this:

 -    DEPENDS bottle_neck
 +    DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/bottle_neck

in order to ensure the optimization is used for the test to
finish within the timeout.

Also the test does not work well on Windows because the
filesystem is very slow to deal with a large number of
files and directories.  Even removing creation of the
input_${i} files the 1000 output-target build makefiles
take forever to write.

IMO it is not worth the effort to establish this test.
We have no performance tests elsewhere and it is unlikely
this will regress.  The way the lookup is done with your
patches is the way it should have been done originally.

-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to