On 2/14/2014 3:48 PM, Steve Wilson wrote:
> In the refactor of these functions, would you like to see that
> refactor as a separate commit or merged in with the commit for
> the other changes?

I have a slight preference for a separate commit that first
factors the common part out and calls it from the one site,
and then the main commit that adds the new call site.  I
wouldn't reject it (for that reason) either way though.

Thanks,
-Brad
-- 

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to