Interesting, I’ll revisit it.

On Feb 17, 2014, at 8:43 AM, Brad King <brad.k...@kitware.com> wrote:

> On 02/14/2014 04:24 PM, Steve Wilson wrote:
>> new method OutputDefinitionsByTag and adds an argument that lets you specify 
>> the tag.    I also fixed the test case.
> 
> Thanks.  I don't see in the new changes where it actually uses the
> parsed Undefines member.  It looks like it just adds the main
> definitions with both UndefinePreprocessorDefintions and
> PreprocessorDefintions.  Shouldn't OutputDefinitionsByTag take
> an argument telling it what list of definitions to use, and then
> used as an implementation detail of OutputPreprocessorDefinitions
> and OutputUndefinePreprocessorDefinitions?
> 
> -Brad
> 

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

-- 

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to