If I understand correctly all modules included via include/find_package have 
implicit POLICY PUSH and POP at the EOF. Wouldn't it be reasonable to require 
all internal .cmake files to begin with:

        cmake_policy(VERSION 3.1) # or whatever version the module was tested 
against

Then before next release all of these should be checked against new policies 
and upgraded to:

        cmake_policy(VERSION 3.2) # next release version

Then we can safely drop all these fancy if("x${var}" STREQUAL "xVALUE") in 
favor of if(var STREQUAL "VALUE") and improve scripts readability, rather that 
do PUSHes and POPs in various places. Of course I am aware that such task needs 
lot of work, however I think this should be consequence of introducing CMP0054.

--Adam

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to