On 11/10/2014 04:49 PM, Ruslan Baratov wrote: > On 31-Oct-14 16:39, Brad King wrote: >> Please work on the patches. You can use "git format-patch" to format >> them and post here either inline or as attachments. >> > Done
Thanks for working on it. Good start. Here are some comments so far: * All headers and sources need to include cmStandardIncludes.h first, directly or indirectly through other headers. It can affect the way certain standard library headers are preprocessed on some platforms, and needs to be consistent across all translation units. * Please add the .cxx files to 'bootstrap' and Source/CMakeLists.txt rather than including them in cmBootstrapCommands*.cxx. * The windows header should be included in lower case <windows.h>. * The cerrno and cstdio headers need to be just errno.h and stdio.h to work on some of the older compilers. * Please add documentation to Help/command/file.rst and anywhere else that is appropriate. * Please add test cases for all APIs and error cases, probably in Tests/RunCMake/file using the RunCMake infrastructure. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
