On 11/13/2014 09:01 AM, Ruslan Baratov wrote:
>> * Please add documentation to Help/command/file.rst and anywhere else
>>    that is appropriate.
> Done

Thanks.  I will try out the patch when I get a chance to provide further
feedback.

> Is it possible to run tests only from 'Tests/RunCMake/file' directory?

ctest -R RunCMake.file -V

> By the way I got the following error (Visual Studio 2013) if I include 
> 'cmFileLockResult.h' before 'cm_curl.h' in file 'cmFileCommand.cxx':
> Compiles fine if 'cmFileLockResult.h' placed after 'cm_curl.h'.

Okay.

One comment from a quick scroll through the patches:

- Use ConvertToWindowsExtendedPath for passing file paths to windows
  APIs.  That will allow use of longer path names.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to