Stephen Kelly wrote: > This looks like it needs a suffix. GSL_CONFIG_EXECUTABLE would seem > appropriate.
>> # Windows with dlls, but only Release libraries.
>> set_target_properties( GSL::gslcblas PROPERTIES
>> IMPORTED_LOCATION "${GSL_CBLAS_LIBRARY_DLL}"
> This should be IMPORTED_LOCATION_RELEASE
I made both of these recommended changes.
I also fixed a single instead of a double colon typo in the dll
section (GSL:gsl -> GSL::gsl). The updated file is attached.
How does cmake provide tests for modules like this? How is the correctness of
the module checked before a release? Do you simply rely on release candidates?
-kt
FindGSL.cmake
Description: FindGSL.cmake
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
