On 12/16/2014 01:36 PM, Thompson, KT wrote: > I also reverted a recent change by replacing GSL_CONFIG_EXECUTABLE > with GSL_CONFIG to remain consistent with the naming conventions > of PkgConfig.cmake.
The convention is for libraries to be FOO_LIBRARY and executables to be FOO_EXECUTABLE. PkgConfig is an exception for historical reasons. I updated the patch for you to use GSL_CONFIG_EXECUTABLE. > The updated FindGSL.cmake is attached. Thanks. I've applied it and merged for testing: FindGSL: Add module to find the GNU Scientific Library http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1b28e3b2 I also fixed repeat inclusion with: -if( GSL_FOUND ) +if( GSL_FOUND AND NOT TARGET GSL::gsl ) > I also created a simple test for the new module (see attached FindGSL.tgz). I created a test based on that, thanks. I chose to use just + if(CMake_TEST_FindGSL) + add_subdirectory(FindGSL) + endif() so that the build of CMake itself does not try to search for a library CMake does not need (this needs to be fixed up for a few other find module tests, but that is not your problem). Therefore in your dashboard script please add: set( dashboard_cache "CMake_TEST_FindGSL:BOOL=ON") Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
