On 01/28/2015 07:31 AM, Brian Smith wrote:
> This patch is an attempt to fix
> http://www.cmake.org/Bug/view.php?id=15253. As noted in the bug, this
> affects the Chromium BoringSSL build.
Thanks for working on this.
> - std::string flags = "$FLAGS";
> + std::string flags;
> +
> + if (lang == "C" || lang == "CXX" || lang == "RC")
> + {
> + flags += "$FLAGS";
> + }
Why is this hunk needed? The $FLAGS placeholder should be
okay for any language because the corresponding build rules
should be generated with the proper FLAGS value.
> else
> {
> deptype = "msvc";
> depfile = "";
> - flags += " /showIncludes";
> + if (lang == "C" || lang == "CXX")
> + {
> + flags += " /showIncludes";
> + }
> }
Without /showIncludes the "msvc" deptype does not make sense.
Should some other code path be used here to get dependencies?
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
