On 01/29/2015 03:02 PM, Brian Smith wrote:
> Also, note that this bug was originally reported by "karlhungus" in
> the bug tracker, but your commit message says it was reported by me.
> It would be great if you could give "karlhungus" the credit for
> reporting the bug instead of me when you merge it into the trunk.

It was your trouble with DEP_FILE in constructing your patch that
lead to the commit.  I've changed it to generically reference the
issue tracker entry instead:

 Ninja: Use "deps = msvc" only for C and CXX (#15253)
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8a93d3ea

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to