Brad King wrote: > Steve, > > In regard to: > > Revert "cmQtAutoGenerators: Fix rcc invocation for Qt 5.0 and 5.1 > (#15644)" https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=08147a9a > > The proper fix is to detect whether rcc supports --list or -list and user > the preferred one based on the version available, not to revert to the > broken state.
I consider CMake 3.4 to be the broken state. The patch reverted in that topic removed the use of a documented command line option and added the use of an undocumented command line option. I don't see any reason to add maintenance burden for long-obsolete Qt versions to new CMake versions. Maintenance burden in CMake is already far beyond reasonable :). Adding conditions which are not tested, and which must be maintained in future refactoring is the mistake. > I will not merge the topic as-is. That's up to you. I wanted to stick my pin in the map on this as the person who wrote the feature :). Thanks, Steve. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
